On Wed, 1 Jun 2011, Matthew Wilcox wrote: > On Wed, Jun 01, 2011 at 03:31:40PM -0400, Alan Stern wrote: > > On Wed, 1 Jun 2011, Sergei Shtylyov wrote: > > > > > Hello. > > > > > > Matthew Wilcox wrote: > > > > > > >>> Since commit 5153b7b3 the trb pointer was only assigned, not dereferenced. > > > > > > >> Please also specify that commit's summary -- for the human readers. > > > > > > > Why are human readers unable to type 'git show 5153b7b3'? > > > > > > They may not have the git tree? > > > > Also, it's what Linus has asked people to do. > > I've missed that. Do you have a reference? I wish I did. It was one of those things that goes by quickly and you don't realize at the time that later on people will want to refer back to it. I don't even remember how long ago it was... Probably somewhere between one and two years but maybe more. > > More to the point, this is a matter of courtesy. Sure, you can save > > yourself 10 seconds of copy & paste, at the cost of making dozens of > > readers expend a similar amount of time to learn what you're talking > > about. If you expect people to read what you write, it's good form not > > to force them to go out of their way to understand you. > > The thing is, it's not relevant to this commit. The changelog could > easily be, > > "This pointer is only assigned to, not dereferenced" > > But I put in the extra effort of figuring out why it's assigned (digging > back through git history) so nobody else has to spend 90 seconds > doing that. But that's actually the only bit that's interesting. > The summary of the commit doesn't provide you with any more information. > > I can easily see that for some changelogs, that's not the case (and > those are probably the ones Linus was referring to). Quite possibly so. Most likely he wouldn't have mentioned it in a context where the commit was only marginally relevant to the topic at hand. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
