[PATCH] USB: EHCI: Remove SPARC_LEON {read,write}_be definitions from ehci.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



{read,write}l_be are now defined for SPARC and do not need to be
defined for SPARC_LEON in ehci.h. This patch fixes the following
warnings:

  CC      drivers/usb/host/ehci-hcd.o
In file included from drivers/usb/host/ehci-hcd.c:119:
drivers/usb/host/ehci.h:631:1: warning: "readl_be" redefined
...
drivers/usb/host/ehci-hcd.c:119:
drivers/usb/host/ehci.h:632:1: warning: "writel_be" redefined
...

Signed-off-by: Jan Andersson <jan@xxxxxxxxxxx>
---

Hi Greg,

The defines for SPARC_LEON were added to ehci.h by commit:

9be0392989306361d4a63a06a8ee281efbead548

currently in usb-next. {read,write}l_be were later added to the
SPARC arch after comments when submitting patches to support big
endian UCHI HCs. The {read,write}*_be additions to SPARC are currently
in the sparc-2.6 tree. The patch to add them is also included in the

[PATCH V6 0/5] USB: UHCI: Add support for big endian GRUSBHC

series that I hope you will pick up.

Best regards,
  Jan
---
 drivers/usb/host/ehci.h |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index f68e419..bd6ff48 100644
--- a/drivers/usb/host/ehci.h
+++ b/drivers/usb/host/ehci.h
@@ -628,9 +628,6 @@ ehci_port_speed(struct ehci_hcd *ehci, unsigned int portsc)
 #if defined(CONFIG_ARM) && defined(CONFIG_ARCH_IXP4XX)
 #define readl_be(addr)		__raw_readl((__force unsigned *)addr)
 #define writel_be(val, addr)	__raw_writel(val, (__force unsigned *)addr)
-#elif defined(CONFIG_SPARC_LEON)
-#define readl_be(addr)		__raw_readl(addr)
-#define writel_be(val, addr)	__raw_writel(val, addr)
 #endif
 
 static inline unsigned int ehci_readl(const struct ehci_hcd *ehci,
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux