On Wed, 18 May 2011, Karl Relton wrote:
> Commits ae38c78a03e1b77ad45248fcf097e4568e740209
> and 00914025cc4e783d4703b4db1d47b41f389e50c8 added quirk flags
> US_FL_NO_READ_DISC_INFO and US_FL_NO_READ_CAPACITY_16 to
> the usb-storage driver. However they did not add the corresponding flags
> to adjust_quirks() in usb.c, so there was no facility for a user
> to over-ride/add them via the quirks module parameter.
>
> Signed-off-by: Karl Relton <karllinuxtest.relton@xxxxxxxxxxxx>
>
> --- a/drivers/usb/storage/usb.c 2011-03-15 01:20:32.000000000 +0000
> +++ b/drivers/usb/storage/usb.c 2011-05-18 20:01:10.605198186 +0100
> @@ -439,7 +439,8 @@ static void adjust_quirks(struct us_data
> US_FL_CAPACITY_HEURISTICS | US_FL_IGNORE_DEVICE |
> US_FL_NOT_LOCKABLE | US_FL_MAX_SECTORS_64 |
> US_FL_CAPACITY_OK | US_FL_IGNORE_RESIDUE |
> - US_FL_SINGLE_LUN | US_FL_NO_WP_DETECT);
> + US_FL_SINGLE_LUN | US_FL_NO_WP_DETECT |
> + US_FL_NO_READ_DISC_INFO | US_FL_NO_READ_CAPACITY_16);
>
> p = quirks;
> while (*p) {
> @@ -471,6 +472,12 @@ static void adjust_quirks(struct us_data
> case 'c':
> f |= US_FL_FIX_CAPACITY;
> break;
> + case 'd':
> + f |= US_FL_NO_READ_DISC_INFO;
> + break;
> + case 'e':
> + f |= US_FL_NO_READ_CAPACITY_16;
> + break;
> case 'h':
> f |= US_FL_CAPACITY_HEURISTICS;
> break;
This is fine as far as it goes, but you also need to document the new
code letters under the usb-storage.quirks= entry in
Documentation/kernel-parameters.txt.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
