Re: [PATCH 1/2] usb/isp1760: Move function isp1760_endpoint_disable() within file.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg KH wrote:
> On Tue, May 17, 2011 at 05:53:35PM +0200, Arvid Brodin wrote:
>> Signed-off-by: Arvid Brodin <arvid.brodin@xxxxxxxx>
> 
> Why did you move it?  You didn't say this...
> 

Just as a preparation for patch #2. The function isp1760_endpoint_disable() 
does almost the same thing as urb_dequeue(), and even called urb_dequeue()
before my patch. I changed these to use a common helper function instead to
avoid releasing the spinlock at the wrong time. So it seemed proper to have 
the functions close to each other in the code.

Should I repost the patch series with this comment or are you OK with this?

> thanks,
> 
> greg k-h

-- 
Arvid Brodin
Enea Services Stockholm AB
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux