> The usb_set_intfdata() calls at cdc_ncm_bind() time are unconditional, > and are performed regardless of whether ->data_claimed or > ->control_claimed are set. > > So conditionalizing the setting of them to NULL here doesn't seem > right at all. > > I'm not applying this patch. Looks like I have to pay more attention to bind/unbind code as it was copy-paste to some extent. Looking at cdc-acm and cdc_ether drivers, there is no need to claim control (master) interface neither release it in unbind(). Some confusion was added by other driver code that handles crippled devices, which mix ctrl and data interfaces... Shall not be the case here. I see, that some clean up can be done and "xxx_claimed" fields in context structure can be removed, so will post a new version of patch shortly. Regards, Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
