Re: [lsusb PATCH] Verbose flag in tree mode shows vendor and product name.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The before and after:
[dcrosby@geel usbutils]$ ./lsusb -t
Bus#  4
`-Dev#   1 Vendor 0x1d6b Product 0x0001
 `-Dev#   2 Vendor 0x046d Product 0xc00e
Bus#  3
`-Dev#   1 Vendor 0x1d6b Product 0x0001
 `-Dev#   2 Vendor 0x046d Product 0xc317
Bus#  2
`-Dev#   1 Vendor 0x1d6b Product 0x0002
Bus#  1
`-Dev#   1 Vendor 0x1d6b Product 0x0002
 `-Dev#   2 Vendor 0x05e3 Product 0x0608
   |-Dev#   4 Vendor 0x0d8c Product 0x000e
   `-Dev#   7 Vendor 0x03f0 Product 0x3307

[dcrosby@geel usbutils]$ ./lsusb -tv
Bus#  4
`-Dev#   1 Vendor 0x1d6b Product 0x0001 Linux Foundation 1.1 root hub
 `-Dev#   2 Vendor 0x046d Product 0xc00e Logitech, Inc. M-BJ58/M-BJ69
Optical Wheel Mouse
Bus#  3
`-Dev#   1 Vendor 0x1d6b Product 0x0001 Linux Foundation 1.1 root hub
 `-Dev#   2 Vendor 0x046d Product 0xc317 Logitech, Inc. Wave Corded Keyboard
Bus#  2
`-Dev#   1 Vendor 0x1d6b Product 0x0002 Linux Foundation 2.0 root hub
Bus#  1
`-Dev#   1 Vendor 0x1d6b Product 0x0002 Linux Foundation 2.0 root hub
 `-Dev#   2 Vendor 0x05e3 Product 0x0608 Genesys Logic, Inc. USB-2.0 4-Port HUB
   |-Dev#   4 Vendor 0x0d8c Product 0x000e C-Media Electronics, Inc.
Audio Adapter (Planet UP-100, Genius G-Talk)
   `-Dev#   7 Vendor 0x03f0 Product 0x3307 Hewlett-Packard

I agree - I'm not thrilled with the fact that there's essentially two
different programs to generate the same thing. Is lsusb.py going to be
the actual replacement for the old lsusb? If the C program is going to
stick around, I'll work on integrating the devtree.c code so that
there's less overhead. However, if lsusb.py is going to be the
full-blown replacement for lsusb, I won't waste my (and your) time
with it.

-Dafydd

On Fri, May 13, 2011 at 3:50 PM, Greg KH <greg@xxxxxxxxx> wrote:
> On Fri, May 13, 2011 at 03:37:44PM -0600, Dafydd Crosby wrote:
>> Verbose flag in tree mode shows vendor and product name.
>> When running `lsusb -tv`, devices should have the vendor and
>> product name appended to the row.
>>
>> ÂSigned-off-by: Dafydd Crosby <dtcrsby@xxxxxxxxx>
>
> I hate the fact that the tree mode code is a totally different code
> path and you have to duplicate all of this logic multiple times.
>
> Have you just tried the 'lsusb.py' script that comes with usbutils now?
> That probably shows what you want here, and is a simpler solution as it
> is already coded and shipping in distros.
>
> Oh, and what does the before and after output of this patch look like?
>
> thanks,
>
> greg k-h
>



-- 
http://dafyddcrosby.com - my programming blog
http://lonesomecosmonaut.com - my fun blog
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux