Re: [PATCH] xhci: Fix full speed bInterval encoding.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, May 13, 2011 01:10:01 PM Sarah Sharp wrote:
> Dmitry's patch
> 
> dfa49c4ad120a784ef1ff0717168aa79f55a483a USB: xhci - fix math in
> xhci_get_endpoint_interval()
> 
> introduced a bug.  The USB 2.0 spec says that full speed isochronous
> endpoints' bInterval must be decoded as an exponent to a power of two
> (e.g. interval = 2^(bInterval - 1)).  Full speed interrupt endpoints,
> on the other hand, don't use exponents, and the interval in frames is
> encoded straight into bInterval.
> 
> Dmitry's patch was supposed to fix up the full speed isochronous to
> parse bInterval as an exponent, but instead it changed the *interrupt*
> endpoint bInterval decoding.  The isochronous endpoint encoding was the
> same.

Yep, my bad. Thank you for fixing this.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux