On Wed, May 11, 2011 at 03:15:52PM -0700, Andy Ross wrote:
> The BIOS handoff for the unused EHCI controller on the ExoPC tablet
> hangs for 90 seconds on boot. Detect that device, skip negotiation
> and force the handoff.
>
> Signed-off-by: Andy Ross <andy.ross@xxxxxxxxxxxxx>
> ---
> drivers/usb/host/pci-quirks.c | 35 +++++++++++++++++++++++++----------
> 1 files changed, 25 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index e230a79..be9c0ce 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -14,6 +14,7 @@
> #include <linux/init.h>
> #include <linux/delay.h>
> #include <linux/acpi.h>
> +#include <linux/dmi.h>
> #include "pci-quirks.h"
> #include "xhci-ext-caps.h"
>
> @@ -218,9 +219,20 @@ static void __devinit ehci_bios_handoff(struct pci_dev *pdev,
> void __iomem *op_reg_base,
> u32 cap, u8 offset)
> {
> - int msec, tried_handoff = 0;
> + int tried_handoff = 0, force_handoff = 0;
The logic of "force_handoff" seems odd as you constantly check for it to
be not true. Care to revert this name/logic to make it easier to
follow?
Other than this nit, it looks much better to me and I don't feel scared
about applying it like I did your original version :)
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
