On Wed, May 11, 2011 at 08:39:54AM +0200, Uwe Kleine-König wrote: > Hello Greg, > > On Fri, May 06, 2011 at 11:00:05AM +0200, Uwe Kleine-König wrote: > > Commit > > > > 09ba0de (USB: fsl_udc_core: prepare for SoCs with BE registers and descriptors) > > > > introduced two function pointers _fsl_readl and _fsl_writel in an #ifdef > > CONFIG_PPC32 block and used then unconditionally in fsl_udc_probe. > > To make the driver compile again this use has to be protected by > > an #ifdef, too. Moreover ARM doesn't have flush_dcache_range so this > > is #ifdefed out, too. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > --- > > Hello, > > > > I'm unsure about getting rid of the flush_dcache_range. If powerpc needs > > a flush ARM probably does, too, no? > > If so, what it the right thing to do? Implement flush_dcache_range for > > ARM (just wrapping flush_dcache_page?)? > As Russell seem to be OK with the #ifdef, can you please take this > patch? Ick, no. > > drivers/usb/gadget/fsl_udc_core.c | 4 ++++ > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c > > index 999eafe..47152e0 100644 > > --- a/drivers/usb/gadget/fsl_udc_core.c > > +++ b/drivers/usb/gadget/fsl_udc_core.c > > @@ -1333,8 +1333,10 @@ static void ch9getstatus(struct fsl_udc *udc, u8 request_type, u16 value, > > /* Fill in the reqest structure */ > > *((u16 *) req->req.buf) = cpu_to_le16(tmp); > > > > +#ifdef CONFIG_PPC32 > > /* flush cache for the req buffer */ > > flush_dcache_range((u32)req->req.buf, (u32)req->req.buf + 8); > > +#endif Come on, we don't have ifdefs in .c files for a reason, surely there is a better fix for this some other way? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
