Re: [PATCH V2 4/4] USB: UHCI: Support big endian GRUSBHC HC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/05/11 19:46, Jan Andersson wrote:
> This patch adds support for big endian GRUSBHC UHCI controllers.
> The HCD bus glue will probe the register interface to determine
> the endianness of the controller.
> 
> Tested on GR-LEON4-ITX board which has a controller with little endian
> interface and on custom LEON3 board with a BE controller.
> 
> Signed-off-by: Jan Andersson <jan@xxxxxxxxxxx>
> ---
> Changes for patch V2:
> Updated added comment in uhci-grlib.c
> Assign uhci->big_endian_mmio instead of function pointers
> ---
>  drivers/usb/host/Kconfig      |    6 ++++--
>  drivers/usb/host/uhci-grlib.c |   17 +++++++++++++++++
>  drivers/usb/host/uhci-hcd.h   |   11 ++++++++++-
>  3 files changed, 31 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 5844248..ab085f1 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -418,11 +418,13 @@ config USB_UHCI_SUPPORT_NON_PCI_HC
>  
>  config USB_UHCI_BIG_ENDIAN_MMIO
>  	bool
> -	depends on USB_UHCI_SUPPORT_NON_PCI_HC
> +	depends on USB_UHCI_SUPPORT_NON_PCI_HC && SPARC_LEON
> +	default y
>  
>  config USB_UHCI_BIG_ENDIAN_DESC
>  	bool
> -	depends on USB_UHCI_SUPPORT_NON_PCI_HC
> +	depends on USB_UHCI_SUPPORT_NON_PCI_HC && SPARC_LEON
> +	default y
>  
>  config USB_FHCI_HCD
>  	tristate "Freescale QE USB Host Controller support"
> diff --git a/drivers/usb/host/uhci-grlib.c b/drivers/usb/host/uhci-grlib.c
> index b1addd6..81f741a 100644
> --- a/drivers/usb/host/uhci-grlib.c
> +++ b/drivers/usb/host/uhci-grlib.c
> @@ -25,6 +25,23 @@ static int uhci_grlib_init(struct usb_hcd *hcd)
>  {
>  	struct uhci_hcd *uhci = hcd_to_uhci(hcd);
>  
> +	/* Assign function pointers that will be used for register accesses.
> +	 * Probe to see if we have a big or little endian controller. Bit 7

Crap, I forgot to update the first part of that comment. And I suppose I
should have added "From: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>" to
patch 2. I will wait a while for any comments and then resend this
series with those two things fixed.

Best regards,
  Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux