On Thu, May 05, 2011 at 09:59:18AM -0700, Sarah Sharp wrote: > On Thu, May 05, 2011 at 06:13:47PM +0800, Andiry Xu wrote: > > Hi Sarah, > > > > This is xHCI 1.0 compliance patchset based on your for-usb-next branch. > > It includes some new field setting and error handlers defined by xHCI > > 1.0 spec, some clarifications for ambiguous descriptions and new > > features. > > > > The Block Event Interrupt feature is used to reduce the interrupt rate > > and can improve the system performance for isoc transfer. > > Wonderful, thank you! I'll look over your patches and get back to you > soon. Hi Andiry and Alex, Thanks for pushing these patches. It's getting very close to the 2.6.40 merge window, and I'm a bit concerned about pushing some of the larger patches this late in the 2.6.39 release cycle. I'm going to push to Greg a subset of this series that seems fairly straight forward and didn't have much controversy during the review process. Here's what I'll push: [RFC 1/9] xHCI 1.0: Setup Stage TRB Transfer Type flag [RFC 2/9] xHCI 1.0: Control endpoint average TRB length field set [RFC 3/9] xHCI 1.0: Isoch endpoint CErr field set [RFC 4/9] xHCI 1.0: Block Interrupts for Isoch transfer [RFC 5/9] xHCI 1.0: TT_THINK_TIME set [PATCH 9/9] xHCI 1.0: Max Exit Latency Too Large Error I'd like to take a longer look at the sixth patch, "xHCI 1.0: Soft Retry mechanism" because it will change the current hardware behavior and it's a larger chunk of code. The seventh and eighth patches have already been reviewed and just need to be fixed. I'm actually not really sure what to make of the "xHCI 1.0: Force Stopped Event(FSE)" patch. Your patch description doesn't tell me why you need this, and it doesn't very clearly explain what you're trying to do. I think that it's going to effect the cancellation code, is that correct? If so, you need to give some details on how it will effect the cancellation code, because that code is fairly hairy. The patch also seems to be thrown together rather fast, if the number of spelling mistakes are any indication. Has it been throughly tested? Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
