On Fri, 6 May 2011, Alex He wrote: > > That sounds right, except that URBs with low-level communication > > errors > > should complete with an error code of -EPROTO or -EILSEQ (there's not > > much difference between the two). > > The slot will be disabled when the device is disconnected. > > But the error value of handle_tx_event() or handle_cmd_completion() in > xhci_irq() can't be transfered to the USB core level. Even the return > type of the handle_cmd_completion() is void.So I make the xhci driver to > do the disable slot command. > > Do you have other way to info the USB core about it? I'm not familiar with the internal design of xhci-hcd, but clearly it must have some method for completing an URB with an error status. You should use that method. For example, what happens if the USB cable is unplugged while an URB is being transferred? Some routine under xhci_irq() would see that the data wasn't sent correctly, and it would cause the URB to complete with an error status but it wouldn't disable the slot. You're in exactly the same kind of situation. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
