Hi Sarah, On Thu, May 05, 2011 at 08:07:31PM -0700, Sarah Sharp wrote: > + case COMP_STOP_INVAL: > + case COMP_STOP: > + goto set_stop_td; Stylistic comment: why don't you do: return finish_td(xhci, td, event_trb, event, ep, status, false); right here instead of jumping to a label - I think it makes logic cleared. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html