On Thu, 5 May 2011, Jan Andersson wrote: > >> USB_UHCI_SUPPORT_NON_PCI_HC is currently needed to include the necessary > >> stuff for the non-PCI HC so that one must be set. One additional option > >> could be introduced to still include the accesses to the legacy support > >> register. Another way to solve this would be to add defined(CONFIG_X86) > >> in uhci-pci.c (change to patch 6 in V2): > > > > A better approach is for uhci-pci always to call the reset functions in > > pci-quirks. That's what you were planning to do originally, right? > > > > Yes that was done in the first patch and (to state the obvious) it is > done now in V2 unless USB_UHCI_SUPPORT_NON_PCI_HC is set. I'll add the > && !x86 to USB_UHCI_SUPPORT_NON_PCI_HC if you think that it is the best > option. No, I think it's best simply to have the reset methods in uhci-pci.c call the functions in pci-quirks.c always, rather than sometimes calling the generic functions in uhci-hcd.c. Then the generic functions can be protected by "#ifdef CONFIG_USB_UHCI_SUPPORT_NON_PCI_HC". Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
