On 05/04/2011 11:47 PM, Alan Stern wrote: > On Wed, 4 May 2011, Jan Andersson wrote: > >> On 04/05/11 21:58, Alan Stern wrote: >>> On Wed, 4 May 2011, Jan Andersson wrote: >>> >>>> Hi, >>>> >>>> This series adds support for the GRUSBHC UHCI host controller found on some >>>> LEON/GRLIB SoCs. Patches 1 - 6 convert the UHCI HCD to be able to support >>>> non-PCI host controllers and patch 7 adds bus glue for the non-PCI HC. >>>> >>>> I have tried to make the steps easy to follow by first partitioning parts that >>>> depend on PCI and then moving these parts to uhci-pci.c. After that some >>>> checkpatch warnings on the existing code are fixed. The sixth patch wraps the >>>> register access calls and the seventh patch adds glue for the non-PCI HC. >>>> >>>> Each patch is compile tested. Tests have been run on x86 (with Intel 82801EB/ER >>>> (ICH5/ICH5R) USB UHCI Controller #4 (rev 02)) and LEON/SPARC32 with the full >>>> series applied. >>> >>> Interesting. Do these parts include a companion EHCI controller? >>> >> >> Yes, a patch for the EHCI part of the controller is in usb-next. Port >> handling is standard, UHCI gets control when EHCI isn't configured or >> via the port owner bit(s) in the EHCI port control register(s). > > Then you will need to duplicate somehow the fancy logic in hcd-pci.c > for associating companion controllers. It is necessary for insuring > that the controllers, root hubs, and the devices under them are resumed > in the proper order so that handoffs from EHCI to UHCI can occur > correctly following hibernation. > Thanks for the heads up. I know very little about PM on Linux so I will need to read up on the topic. AFAIK it is not common to (attempt to) use PM with LEON. Anyway, I will look into this but, unless you object, I will not add that logic to this patchset. Best regards, Jan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
