On Wed, 4 May 2011, Jan Andersson wrote: > >> I did not implement this as it leads to more code being added. When/If > >> support for big endian registers is added then perhaps it would be better > >> to use function pointers when supporting non-PCI hosts. > > > > Seems like a reasonable choice. > > Thanks. I plan to add support for big endian mmio and descriptors later > on and will change to function pointers then. Are there any big-endian machines that will use this controller? > Thank you very much for reviewing. I try to address all of your and > Sergei's comments and send a V2 after I have slept and tested. Something else to think about... The uhci_grlib_reset_hc() and uhci_grlib_check_and_reset_hc() routines are all generic -- there's nothing specific to the GRUSBHC about them. They could go into uhci-hcd.c. The reason they aren't there now is because they are part of the BIOS handoff needed by the early PCI code, even before uhci-hcd might be loaded. Therefore a copy had to go into pci-quirks.c, and there was no reason to duplicate it in uhci-hcd.c. Since you don't have to worry about taking control from the firmware, the routines don't need to be coded separately for each platform. You can put a generic version in uhci-hcd.c, and if the build is PCI-only then the generic routine can simply call the pci-quirks code. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
