Re: [PATCH 4/7] USB: UHCI: Codingstyle fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 4 May 2011, Jan Andersson wrote:

> This patch is part of a series that extend the UHCI HCD to support
> non-PCI host controllers.
> 
> This patch fixes the following warnings from checkpatch:
> 
> ERROR: switch and case should be at the same indent
> +	switch (to_pci_dev(uhci_dev(uhci))->vendor) {
> +	    default:
> [...]
> +	    case PCI_VENDOR_ID_GENESYS:
> [...]
> +	    case PCI_VENDOR_ID_INTEL:
> 
> WARNING: static char array declaration should probably be static const char
> +	static char bad_Asus_board[] = "A7V8X";
> 
> WARNING: braces {} are not necessary for single statement blocks
> +	else {
> +		check_and_reset_hc(uhci);
> +	}

This warning is a false positive.  It doesn't need to be fixed.

Alan Stern


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux