On Tue, May 03, 2011 at 09:56:38PM +0200, matthieu castet wrote: > Hi Greg, > > Le Fri, 29 Apr 2011 17:30:57 -0700, > Greg KH <greg@xxxxxxxxx> a écrit : > > > On Thu, Apr 21, 2011 at 01:32:32PM -0700, Greg KH wrote: > > > On Thu, Apr 21, 2011 at 10:08:10PM +0200, matthieu castet wrote: > > > > > > > > This allow to clean duplicated code in most of SOC driver. > > > > > > > > Signed-off-by: Matthieu CASTET <castet.matthieu@xxxxxxx> > > > > --- > > > > drivers/usb/host/ehci-atmel.c | 20 +------------------- > > > > drivers/usb/host/ehci-cns3xxx.c | 10 +--------- > > > > drivers/usb/host/ehci-fsl.c | 21 ++------------------- > > > > drivers/usb/host/ehci-hcd.c | 29 > > > > +++++++++++++++++++++++++++++ drivers/usb/host/ehci-ixp4xx.c > > > > | 7 +------ drivers/usb/host/ehci-msm.c | 20 > > > > +------------------- drivers/usb/host/ehci-mxc.c | 17 > > > > +---------------- drivers/usb/host/ehci-orion.c | 14 > > > > +------------- drivers/usb/host/ehci-ppc-of.c | 19 > > > > +------------------ drivers/usb/host/ehci-ps3.c | 19 > > > > +------------------ drivers/usb/host/ehci-sh.c | 16 > > > > +--------------- drivers/usb/host/ehci-spear.c | 10 > > > > +--------- drivers/usb/host/ehci-xilinx-of.c | 15 > > > > +-------------- 13 files changed, 42 insertions(+), 175 > > > > deletions(-) > > > > > > Very nice. And I'm guessing you tested this out on some of these > > > other SOC devices? > > > > Ok, as you didn't respond, I'm guessing not, so I'm dropping it from > > my patch queue. Please resend when you test it. > Sorry for the late reply. > > I checked it was correctly building for some of them, but I don't have > the hardware to test. You don't have the hardware for any to test at least one? > Most of them is : remove the duplicated code and call the generic code > (that is same code that removed one). > > How do you want to proceed with this patch ? > I submit the generic code. And let's each soc driver maintainer test > and submit a patch for their soc ? Yes. It looks like you subtly change some of the logic in some of these boards which might not be good. > Or all the patch is applied and potential regression will be catch > by SOC users ? I'd prefer not to do that. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
