Re: [PATCH] omap:usb: fixing ehci phy gpio values for omap3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 2, 2011 at 5:24 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> On Mon, May 02, 2011 at 05:01:05PM +0530, Munegowda, Keshava wrote:
>> On Mon, May 2, 2011 at 3:08 PM, Felipe Balbi <balbi@xxxxxx> wrote:
>> > On Thu, Apr 21, 2011 at 07:52:42PM +0530, Keshava Munegowda wrote:
>> >> From: Keshava Munegowda <Keshava_mgowda@xxxxxx>
>> >>
>> >> The gpio of EHCI phy should be 0 instead of 1;
>> >> This fixes the hub enumeration issue in beagle xm board.
>> >>
>> >> Signed-off-by: Keshava Munegowda <keshava_mgowda@xxxxxx>
>> >
>> > applied, thanks
>> >
>> > --
>> > balbi
>>
>> Thanks balbi
>>
>> but ,.his patch is was made by Juergen Kilb ( patch description  and link is
>> given below); But I was not aware of it and reinvented wheel with
>> beagle-xm board :(
>>
>> So, Juergen Kilb is the first author of this patch.
>>
>> Here is the link :
>> http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg48215.html
>>
>>   omap:usbhs:Fixed gpio polarity of gpio USB-phy reset
>>
>>     With commit 19403165 a main part of ehci-omap.c moved to
>>     drivers/mfd/omap-usb-host.c created by commit 17cdd29d.
>>     Due to this reorganisation the polarity used to reset the
>>     external USB phy changed and USB host doesn't recognize
>>     any devices.
>>
>>     Signed-off-by: Juergen Kilb <J.Kilb@xxxxxxxxx>
>
> I sent a pull request to Greg with that patch in, so it looks like
> Samuel also didn't send this patch before. Can you reply to the pull
> request I sent saying that this patch should be dropped just so Greg
> knows and I recreate the branch and send another pull request ?
>
> --
> balbi

yes Balbi, I have send a mail to Greg.

once again, I am sorry ,  this patch came in 14th april and i was
returning from ELC-2011. I missed it.

regards
keshava
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux