On Sun, 2011-05-01 at 13:00 +0200, L. Alberto GimÃnez wrote: > From: David Hill <david.hill@xxxxxxxxxxx> > > Since commit ea812ca1b06113597adcd8e70c0f84a413d97544, NET_IP_ALIGN changed from > 2 to 0. Some people have reported that tethering stopped working and David Hill > submited a patch that seems to fix the problem. > > I have no more an iPhone device to test it, so it is only compile-tested. > > Signed-off-by: L. Alberto GimÃnez <agimenez@xxxxxxxxxxx> > --- > drivers/net/usb/ipheth.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/usb/ipheth.c b/drivers/net/usb/ipheth.c > index 7d42f9a..711346b 100644 > --- a/drivers/net/usb/ipheth.c > +++ b/drivers/net/usb/ipheth.c > @@ -54,6 +54,9 @@ > #include <linux/usb.h> > #include <linux/workqueue.h> > > +#undef NET_IP_ALIGN > +#define NET_IP_ALIGN 2 > + > #define USB_VENDOR_APPLE 0x05ac > #define USB_PRODUCT_IPHONE 0x1290 > #define USB_PRODUCT_IPHONE_3G 0x1292 No, you can't do this. If there is some reason to use a fixed alignment of 2 (which I find hard to believe; this is a USB device after all) then that should be specified as a private constant. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
