Hi Sergei
Thanks for review.
On 4/28/2011 8:19 PM, Sergei Shtylyov wrote:
> Hello.
>
> Pavankumar Kondeti wrote:
>
>> Signed-off-by: Pavankumar Kondeti <pkondeti@xxxxxxxxxxxxxx>
> [...]
>
>> diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c
>> index 425418d..fe040a2 100644
>> --- a/drivers/usb/otg/msm_otg.c
>> +++ b/drivers/usb/otg/msm_otg.c
>> @@ -167,6 +167,32 @@ put_3p3:
>> return rc;
>> }
>>
>> +#ifdef CONFIG_PM_SLEEP
>> +static int usb_phy_susp_dig_vol = 500000;
>
> What's the point of making this variable? It doesn't seem to be changed
> anywhere...
>
Correct. I will change it to a macro.
>> @@ -489,6 +516,10 @@ static int msm_otg_suspend(struct msm_otg *motg)
>> */
>> writel(readl(USB_USBCMD) | ASYNC_INTR_CTRL | ULPI_STP_CTRL, USB_USBCMD);
>>
>> + if (motg->pdata->phy_type == SNPS_28NM_INTEGRATED_PHY &&
>> + motg->pdata->phy_type == OTG_PMIC_CONTROL)
>
> This is never true, I guess. Did you mean || ISO &&?
>
:-(
It should be
if (motg->pdata->phy_type == SNPS_28NM_INTEGRATED_PHY &&
motg->pdata->otg_control == OTG_PMIC_CONTROL)
^^^^^^^^^^^
Thanks,
Pavan
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
