Re: [PATCH] USB: xhci - also free streams when resetting devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 13, 2011 at 09:57:37AM -0700, Dmitry Torokhov wrote:
> On Wed, Apr 13, 2011 at 09:52:26AM -0700, Sarah Sharp wrote:
> > On Wed, Apr 13, 2011 at 09:48:41AM -0700, Dmitry Torokhov wrote:
> > > On Wed, Apr 13, 2011 at 09:38:18AM -0700, Sarah Sharp wrote:
> > > > On Tue, Apr 12, 2011 at 11:06:28PM -0700, Dmitry Torokhov wrote:
> > > > > Currently, when resetting a device, xHCI driver disables all but one
> > > > > endpoints and frees their rings, but leaves alone any streams that
> > > > > might have been allocated. Later, when users try to free allocated
> > > > > streams, we oops in xhci_setup_no_streams_ep_input_ctx() because
> > > > > ep->ring is NULL.
> > > > > 
> > > > > Let's free not only rings but also stream data as well, so that
> > > > > calling free_streams() on a device that was reset will be safe.
> > > > 
> > > > Thanks for catching this.  I think Matthew Wilcox sent me a similar
> > > > patch months ago and it got lost in my inbox somewhere. :(  I'll queue
> > > > this as soon as I get the other USB 3.0 hub fixes settled.
> > > 
> > > Thanks Sarah.
> > > 
> > > Do you think we should also mark it for stable? Latest Ubuntu enabled
> > > UAS driver so this issue might bite people in cases when the device is
> > > coming and going for some reason.
> > 
> > Yes, I'll mark it for stable, and Matthew's patch too.  Interesting that
> > Ubuntu decided to turn it on, even though there are (to my knowledge) no
> > devices available commercially yet.  Have you see any?
> 
> I have here XIGMATEK Secure USD03 2.5" & 3.5" USB 3.0 External Docking
> Station:
> 
> http://www.newegg.com/Product/Product.aspx?Item=N82E16817815011

Wow, is that really a UAS device?  I've seen, and bought, a bunch of USB
3.0 disk devices but have not seen a UAS one "in the wild" yet.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux