On Fri, 8 Apr 2011, Kristen Carlson Accardi wrote: > > Also, the patch assumes that ehci_threaded_irq will be called only in > > response to interrupt events. That isn't (or at least, it isn't > > supposed to be) true. There are places where usb_hcd_irq() is invoked > > directly from other code. > > This is true, and the xhci driver wants to use it as a regular irq > handler if MSI doesn't work for them. I suggest we leave usb_hcd_irq > unmodified, and add a new irq handler usb_hcd_quickcheck_irq() to be > used if we have threaded irq, and implement host ops to be: > .irq (regular irq handler, no threaded irq available) > .quickcheck_irq (just do the intr mask and nothing else_ > .threaded_irq (the threaded irq that goes with the quickcheck irq) > > quickcheck and threaded irq would be called at interrupt time only, > the other entry point should work as it did previously. You can > probably share most code between the existing irq and the threaded_irq. Perhaps the existing irq and threaded_irq can even be the _same_. After all, they need to do pretty much the same things. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
