Re: [PATCH] usb: gadget: file_storage: don't assume wMaxPacketSize to be 512

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Apr 7, 2011 at 4:39 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, 7 Apr 2011, Mian Yousaf Kaukab wrote:
>
>> On Wed, Apr 6, 2011 at 5:08 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
>> Performance reasons mainly. If short_not_ok is set, we can program the
>> dma for the full buffer length. Otherwise we program it for each
>> packet.
>
> What happens if short_not_ok is set and you program the DMA for the
> full buffer length, but a short packet arrives?
With the current state of things it will most likely hang and wait for
reset. But I have already agreed with you that behavior should not
change even if short_not_ok/short_not_expected is set or not so I need
to fix this in my driver.

>
> Alan Stern
>
>

Thanks,

--
Mian Yousaf Kaukab
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux