Re: [PATCH] usb: hcd: allow wakeups while suspended for Moorestown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 07, 2011 at 02:54:39PM -0700, Kristen Carlson Accardi wrote:
> On Thu, 7 Apr 2011 13:35:02 -0700
> Greg KH <greg@xxxxxxxxx> wrote:
> 
> > On Thu, Apr 07, 2011 at 09:56:54AM -0700, Kristen Carlson Accardi wrote:
> > > > Have you made timing/performance studies, comparing (for example) USB 
> > > > disk throughput with and without threaded interrupts?
> > > >
> > > 
> > > I could never do this with all the different types of hw.  I suggest
> > > that if you decide to move to a threaded irq you have a long period of
> > > testing time where people can determine whether or not it impacts
> > > performance on their own hw.  Just from googling I can see that tglx
> > > did some performance analysis, but you'd have to ask him what the
> > > findings were.
> > 
> > I asked him about this an hour ago, and he found that he got a
> > performance increase in USB throughput switching to threaded irqs,
> > especially for usb-storage devices.
> > 
> > So I'm all for it now, send me the patch and let's see what breaks :)
> > 
> > thanks,
> > 
> > greg k-h
> 
> I sent him an email to see if he'll submit the patches he's been
> testing with -- I figured it'd be better to use those since he's
> got time on them already.

Yes, it turns out that your patch will not work properly on some
hardware in the first place, so his changes are needed.  I see him
working on them right now in front of me in the conference meeting we
are currently sitting in...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux