On Tue, Apr 05, 2011 at 10:54:50AM -0400, Alan Stern wrote: > On Tue, 5 Apr 2011, Felipe Balbi wrote: > > > > Of course, that's not long enough. With SuperSpeed, the buffer size > > > should be increased to at least 64 KB for optimal throughput. > > > > I think 64kb is still too small, we will get Interrupt on every 164 uS. > > I think it's better to either start support sglists and allocate more > > space, or have many different 16kb buffers and set no_interrupt > > whenever necessary > > Either one is doable. But again, I have to wonder if it is worth the > effort. not to worry about that. I was looking for something interesting to do anyway :-) Maybe I'll try to come up with sglists support for the gadget API. > > > Is it really worthwhile to worry about this? With USB-3 you probably > > > want to run a UAS gadget instead of g_file_storage anyway. > > > > I can't be sure what customers will do :-) Of course I can always > > suggest to use UAS as that's definitely better. > > If they want to use g_file_storage in a SuperSpeed gadget, it will > still work. The throughput will just be lower than it could be with > UAS. > > > cool, thanks for the fruitful discussion Alan. I'll wait until you send > > your patch and will rebase mine on top of that :-) Thanks > > And here it is. This patch is _not_ based on Mian's. It also includes > a separate patch that has been submitted to Greg but not yet merged; > you should be able to apply it with little trouble. > > It bumps bulk-OUT transfers up to the next maxpacket boundary, and it > removes the assumption that the maxpacket size divides the block size. > These are more-or-less independent changes, so it will have to be > broken up into several patches for submission. But you can test it > now. Will play with it in a while. Next to the end of this week or the next one. Thanks -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
