Re: [PATCH] USB: Fix trout build failure with ci13xxx_msm gadget

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 04, 2011 at 10:08:18AM +0530, Pavankumar Kondeti wrote:
> This patch fixes the below compilation errors.
> 
>   CC      drivers/usb/gadget/ci13xxx_msm.o
>   CC      net/mac80211/led.o
>   drivers/usb/gadget/ci13xxx_msm.c: In function 'ci13xxx_msm_notify_event':
>   drivers/usb/gadget/ci13xxx_msm.c:42: error: 'USB_AHBBURST' undeclared (first use in this function)
>   drivers/usb/gadget/ci13xxx_msm.c:42: error: (Each undeclared identifier is reported only once
>   drivers/usb/gadget/ci13xxx_msm.c:42: error: for each function it appears in.)
>   drivers/usb/gadget/ci13xxx_msm.c:43: error: 'USB_AHBMODE' undeclared (first use in this function)
> make[4]: *** [drivers/usb/gadget/ci13xxx_msm.o] Error 1
> make[3]: *** [drivers/usb/gadget] Error 2
> 
> MSM USB driver is not supported on boards like trout (MSM7201) which
> has an external PHY.
> 
> Signed-off-by: Pavankumar Kondeti <pkondeti@xxxxxxxxxxxxxx>

the real fix, though, would be to phase out the PHY to
drivers/usb/otg/blablabla.c. ci13xxx_msm.c shouldn't assume the PHY it's
using. That's wrong.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux