Re: [PATCH v2] usb: otg: OMAP4430: Powerdown the internal PHY when USB is disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 22, 2011 at 05:53:42PM +0530, Hema HK wrote:
> Powerdown the internal UTMI PHY when USB is not enabled. This will
> allow the OMAP core domain to transition to retention and offmode.
> 
> Signed-off-by: Hema HK <hemahk@xxxxxx>
> Cc: Felipe Balbi <balbi@xxxxxx>
> ---
>  arch/arm/mach-omap2/usb-musb.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> Index: linux-2.6/arch/arm/mach-omap2/usb-musb.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-omap2/usb-musb.c
> +++ linux-2.6/arch/arm/mach-omap2/usb-musb.c
> @@ -169,5 +169,7 @@ void __init usb_musb_init(struct omap_mu
>  #else
>  void __init usb_musb_init(struct omap_musb_board_data *board_data)
>  {
> +	if (cpu_is_omap44xx())
> +		omap4430_phy_init(NULL);
>  }
>  #endif /* CONFIG_USB_MUSB_SOC */

you didn't fix the dev_* usage in omap4430_phy_init(), that'll cause
NULL pointer deref when you fail to get a clock.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux