On Tue, Mar 22, 2011 at 02:29:41PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 22-03-2011 12:55, Felipe Balbi wrote:
>
> >>Due to the recent changes to musb's glue layers,
> >>we can't compile musb-hdrc as a module - compilation
> >>will break due to undefined symbol musb_debug. In
> >>order to fix that, we need a big re-work of the
> >>debug support on the MUSB driver.
>
> >>Because that would mean a lot of new code coming
> >>into the -rc series, it's best to defer that to
> >>next merge window and for now just disable module
> >>support for MUSB.
>
> >>Once we get the refactor of the debugging support
> >>done, we can simply revert this patch and things
> >>will go back to normal again.
>
> >>Cc: stable@xxxxxxxxxxxxxxx # v2.6.38
>
> >This should be stable@xxxxxxxxxx, bounced the message to that address
> >and fixed patch in my local branch. Sorry for the confusion.
>
> Felipe, I haven't received this patch thru linux-usb; the list
> archive at marc.info also doesn't show it.
Hmm, weird, the list is clearly in Cc on the original patch. Patch below
anyway:
commit 3fcf0749cac98e4991f9e7675c673af99d390cb7
Author: Felipe Balbi <balbi@xxxxxx>
Date: Tue Mar 22 11:31:37 2011 +0200
usb: musb: temporarily make it bool
Due to the recent changes to musb's glue layers,
we can't compile musb-hdrc as a module - compilation
will break due to undefined symbol musb_debug. In
order to fix that, we need a big re-work of the
debug support on the MUSB driver.
Because that would mean a lot of new code coming
into the -rc series, it's best to defer that to
next merge window and for now just disable module
support for MUSB.
Once we get the refactor of the debugging support
done, we can simply revert this patch and things
will go back to normal again.
Cc: stable@xxxxxxxxxx # v2.6.38
Signed-off-by: Felipe Balbi <balbi@xxxxxx>
diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
index 4cbb7e4..74073b3 100644
--- a/drivers/usb/musb/Kconfig
+++ b/drivers/usb/musb/Kconfig
@@ -14,7 +14,7 @@ config USB_MUSB_HDRC
select TWL4030_USB if MACH_OMAP_3430SDP
select TWL6030_USB if MACH_OMAP_4430SDP || MACH_OMAP4_PANDA
select USB_OTG_UTILS
- tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)'
+ bool 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)'
help
Say Y here if your system has a dual role high speed USB
controller based on the Mentor Graphics silicon IP. Then
@@ -30,8 +30,8 @@ config USB_MUSB_HDRC
If you do not know what this is, please say N.
- To compile this driver as a module, choose M here; the
- module will be called "musb-hdrc".
+# To compile this driver as a module, choose M here; the
+# module will be called "musb-hdrc".
choice
prompt "Platform Glue Layer"
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
