Hi, > -----Original Message----- > From: ext Sergei Shtylyov [mailto:sshtylyov@xxxxxxxxxx] > Sent: 21. maaliskuuta 2011 16:21 > To: Jokiniemi Kalle (Nokia-MS/Tampere) > Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; balbi@xxxxxx; > tony@xxxxxxxxxxx; Krogerus Heikki (Nokia-MS/Helsinki); > jhnikula@xxxxxxxxx; Koskinen Ilkka (Nokia-MS/Tampere) > Subject: Re: [PATCH 1/2] USB: twl4030-usb: do board specific phy_power > up/down > > Hello. > > Kalle Jokiniemi wrote: > > > In case some board has special powering sequences for > > the USB tranceiver, call those during __twl4030_phy_power > > calls. > > > This is a preparation patch to allow powering down the > > ISP1707 USB serial tranceiver in Nokia N900. > > > Signed-off-by: Kalle Jokiniemi <kalle.jokiniemi@xxxxxxxxx> > > --- > > drivers/usb/otg/twl4030-usb.c | 9 ++++++++- > > 1 files changed, 8 insertions(+), 1 deletions(-) > > > diff --git a/drivers/usb/otg/twl4030-usb.c b/drivers/usb/otg/twl4030-usb.c > > index 6ca505f..dea99b1 100644 > > --- a/drivers/usb/otg/twl4030-usb.c > > +++ b/drivers/usb/otg/twl4030-usb.c > > @@ -348,13 +348,20 @@ static void twl4030_i2c_access(struct twl4030_usb > *twl, int on) > > > > static void __twl4030_phy_power(struct twl4030_usb *twl, int on) > > { > > - u8 pwr = twl4030_usb_read(twl, PHY_PWR_CTRL); > > + u8 pwr; > > Why change this line? Also, some prefer that initialized variables precede > uninitialized ones... One likes the apple, one likes the orange. I'll change that back, no problem. - Kalle > > > + struct twl4030_usb_data *board = twl->dev->platform_data; > > + > > + pwr = twl4030_usb_read(twl, PHY_PWR_CTRL); > > > > if (on) > > pwr &= ~PHY_PWR_PHYPWD; > > else > > pwr |= PHY_PWR_PHYPWD; > > > > + /* do board specific power up/down, if available */ > > + if (board->phy_power) > > + board->phy_power(twl->dev, 0, on); > > + > > WARN_ON(twl4030_usb_write_verify(twl, PHY_PWR_CTRL, pwr) < 0); > > } > > WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
