Re: [PATCH 1/2] USB: xhci - remove excessive 'inline' markings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 21, 2011 at 07:35:17AM -0700, Sarah Sharp wrote:
> Dmitry,
> 
> Before I accept this patch, I'd like you to double check that those
> lines weren't effected by any of the performance patches I did last
> summer.  I can't remember if those functions were inlined because of
> performance reasons.  I suspect not, but please double check.
> 

Sarah,

I looked through the git history an none of the commits adding inline
functions mention performance improvements.

Normally we try to avoid marking file-local functions as inline since
register pressure is different on different architectures and compiler
has more data than a human to decide whether inlinig makes more sense
in each particular case or not.

Thanks.

-- 
Dmitry

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux