> Filipe Balbi <balbi@xxxxxx> wrote:
Hi Filipe,
> We are now starting to support USB3 controllers on
> Linux, so change all gadget driver device descriptors
> to say they are USB3.0 compliant.
>
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> ---
> drivers/usb/gadget/audio.c | 2 +-
> drivers/usb/gadget/cdc2.c | 2 +-
> drivers/usb/gadget/composite.c | 2 +-
> drivers/usb/gadget/dbgp.c | 2 +-
> drivers/usb/gadget/ether.c | 2 +-
> drivers/usb/gadget/file_storage.c | 4 ++--
> drivers/usb/gadget/g_ffs.c | 2 +-
> drivers/usb/gadget/gmidi.c | 2 +-
> drivers/usb/gadget/hid.c | 2 +-
> drivers/usb/gadget/inode.c | 4 ++--
> drivers/usb/gadget/mass_storage.c | 2 +-
> drivers/usb/gadget/multi.c | 2 +-
> drivers/usb/gadget/ncm.c | 2 +-
> drivers/usb/gadget/nokia.c | 2 +-
> drivers/usb/gadget/printer.c | 4 ++--
> drivers/usb/gadget/serial.c | 2 +-
> drivers/usb/gadget/webcam.c | 2 +-
> drivers/usb/gadget/zero.c | 2 +-
> 18 files changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/usb/gadget/audio.c b/drivers/usb/gadget/audio.c
> index 93b999e..03f0e48 100644
> --- a/drivers/usb/gadget/audio.c
> +++ b/drivers/usb/gadget/audio.c
> @@ -52,7 +52,7 @@ static struct usb_device_descriptor device_desc = {
> .bLength = sizeof device_desc,
> .bDescriptorType = USB_DT_DEVICE,
>
> - .bcdUSB = __constant_cpu_to_le16(0x200),
> + .bcdUSB = cpu_to_le16(0x0300),
>
> .bDeviceClass = USB_CLASS_PER_INTERFACE,
> .bDeviceSubClass = 0,
This won't work. Now the gadget will not be recognized by a USB 2.0
host. The bcdUSB field needs to be dynamically set according to the
speed of the connection.
Are you aware of the similar patches from the folks at codeaurora.org?
http://marc.info/?l=linux-usb&m=129613390420352&w=4
Maybe you should work with them on this.
--
Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
