Re: [PATCH] usb: wwan: fix compilation without CONFIG_PM_RUNTIME

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le vendredi 18 mars 2011 Ã 12:44 +0100, Oliver Neukum a Ãcrit :
> From 2d75f29a693c4844a5421b688db0be5538f54f6e Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oliver@xxxxxxxxxx>
> Date: Fri, 18 Mar 2011 12:36:31 +0100
> Subject: [PATCH] usb: wwan: fix compilation without CONFIG_PM_RUNTIME
> 
> The pm usage counter must be accessed with the proper wrappers
> to allow compilation under all configurations.
> 
> Signed-off-by: Oliver Neukum <oneukum@xxxxxxx>
> ---
>  drivers/usb/serial/usb_wwan.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c
> index 817e6ff..643957f 100644
> --- a/drivers/usb/serial/usb_wwan.c
> +++ b/drivers/usb/serial/usb_wwan.c
> @@ -695,8 +695,7 @@ static void play_delayed(struct usb_serial_port *port)
>  			/* we have to throw away the rest */
>  			do {
>  				unbusy_queued_urb(urb, portdata);
> -				//extremely dirty
> -				atomic_dec(&port->serial->interface->dev.power.usage_count);
> +				usb_autopm_put_interface_no_suspend(port->serial->interface);
>  			} while ((urb = usb_get_from_anchor(&portdata->delayed)));
>  			break;
>  		}

Hmm

I believe you forgot a bit of attribution, dont you ?

Reported-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux