Re: [PATCH] isp1760-hcd: move imask clear after pending work is done

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Richard Retanubun wrote:
This patch moves the HcInterrupt register write to clear the
pending interrupt to after the isr work is done, doing this removes
glitches in the irq line.

Signed-off-by: Richard Retanubun <richardretanubun@xxxxxxxxxxxxx>
---
Hi Sebastian,

I found that moving the imask write after the work removes a 50ns
'glitch' that I saw on the INT line of the switch.
Just wondering if you have specific reasons to clear it right away.

Lets say you get an interrupt and ATL & INT is set. You do ATL. This takes
some time. You do INT. This takes some times. While serving INT the core
gets another ATL packet ready (a new one, not processed yet) and would
issue an Interrupt but it does not because it is still active. Once you
are done with INT you ack both ATL and INT but you did not serve the last
one ATL packet.


Thanks for your time
Richard


Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux