On Sun, Mar 13, 2011 at 09:14:10PM -0700, Sarah Sharp wrote: > > +int usb_hcd_is_primary_hcd(struct usb_hcd *hcd) We have 'bool' so why not use it? > +{ > + if (!hcd->primary_hcd) > + return 1; return true; Also, this is confusing... Shouldn't we always assign primary_hcd pointer to itself, regardless of the controller kind? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html