Re: [RFC v3 4/6] USB: Fix usb_add_hcd() checkpatch errors.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 11, 2011 at 01:36:25PM -0800, Sarah Sharp wrote:
> On Fri, Mar 11, 2011 at 11:52:08AM -0800, Dmitry Torokhov wrote:
> > On Fri, Mar 11, 2011 at 11:42:18AM -0800, Sarah Sharp wrote:
> > > On Thu, Mar 10, 2011 at 09:52:51PM -0800, Dmitry Torokhov wrote:
> > > > On Mon, Mar 07, 2011 at 02:11:50PM -0800, Sarah Sharp wrote:
> > > > > The irq enabling code is going to be refactored into a new function, so
> > > > > clean up some checkpatch errors before moving it.
> > > > > 
> > > > > Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> > > > 
> > > > Looks good to me.
> > > > 
> > > > Reviewed-by: Dmitry Torokhov <dtor@xxxxxxx>
> > > 
> > > Your reviewed-by email (dtor@xxxxxxx) is different from the email you
> > > sent this message from (dmitry.torokhov@xxxxxxxxx).  Which is correct?
> > > 
> > 
> > Both? People use multiple e-mail addresses... You will also see
> > dtor@xxxxxxxxxx address used by me as well. Just pick the tag as is if
> > you decide to bother with addng it to the changelog, otherwise feel free
> > to ignore it.
> > 
> > I guess I should finally fully migrate to gmail, bt then dtor@xxxxxxx is
> > much faster to type ;P
> 
> Ok, no worries.  It's just that we're very careful to make sure that the
> Signed-off-by email addresses match the actual email of the sender.
> It's a contract according to Documentation/SubmittingPatches (see #12),
> and we want to make sure the email address is correct.  I don't think a
> Reviewed-by tag is as big deal as a Signed-off-by tag, but I just
> thought I'd check which email to use. :)

Hm, is it Intel's internal policy? Because as far as I know DCO requires
using one's real name and simply a reachable e-mail address; at least
most of my patches are signed off using dtor@xxxxxxx but sent from (or
committed as) gmail.com address.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux