On Sat, Mar 05, 2011 at 01:54:50AM +0300, Alexey Khoroshilov wrote: > ep_read() acquires data->lock mutex in get_ready_ep() and releases it on > all paths except for one: when usb_endpoint_xfer_isoc() failed. The patch > adds mutex_unlock(&data->lock) at that path. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx> > --- > drivers/usb/gadget/inode.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/gadget/inode.c b/drivers/usb/gadget/inode.c > index 3ed73f4..a01383f 100644 > --- a/drivers/usb/gadget/inode.c > +++ b/drivers/usb/gadget/inode.c > @@ -386,8 +386,10 @@ ep_read (struct file *fd, char __user *buf, size_t > len, loff_t *ptr) > > /* halt any endpoint by doing a "wrong direction" i/o call */ > if (usb_endpoint_dir_in(&data->desc)) { > - if (usb_endpoint_xfer_isoc(&data->desc)) Your patch is line-wrapped and all of the tabs are converted to spaces, making it impossible to apply :( Care to fix your email client and try again? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html