On Sun, 2011-02-27 at 16:19 +0300, Sergei Shtylyov wrote: > Did you run yhe patch thru scripts/checkpatch.pl? Actually I did. I decided not to fix the spaces before parenthesis (because there were lots of them in this file). Alan already told me not to do that. Maybe I should just start my work with a (trivial) patch to clean up stuff like that first. > It has all the tabs > replaced with spaces. Not in my local repository. What must have happened is that this was done by my MUA when I manually copied and pasted the patch and commit message in a draft reply (to retain things like Message-ID information, for threading). I guess this is the way one learns not to do that. Paul -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html