Greg KH wrote:
> On Wed, Feb 23, 2011 at 04:23:53PM +0100, Arvid Brodin wrote:
>> This patch series is meant to clean up the code (removing more of the legacy from the original and quite frankly horrible Philips drivers), and also contain some small bug fixes.
>
> This is not needed to be sent for every patch.
>
>> * Patch 1: Moves to native-endian ptds. This helps users with platform bus connected isp176xs with endianness problems and fixes a bug with non-32-bit io transfers on big endian, straight-connected hardware.
>
> You forgot to add a Signed-off-by: line up here, where the comments for
> the patch is at.
>
>> drivers/usb/host/isp1760-hcd.c | 610 ++++++++++++++-----------------
>> drivers/usb/host/isp1760-hcd.h | 33 -
>> 2 files changed, 307 insertions(+), 336 deletions(-)
>
> You need a "---" line before this diffstat so that the tools will
> properly catch it.
>
> If you use git or quilt to create these, the format will be the correct
> one automatically.
Ok, thanks for the info!
>> diff -Nurp linux-2.6.37/drivers/usb/host/isp1760-hcd.c linux-2.6.37-isp1760-001/drivers/usb/host/isp1760-hcd.c
>
> Can you diff these against Linus's latest tree, or the linux-next tree,
> so that I have a chance that they will apply?
This (Linus' latest tree) would be the
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git tree?
That tree does not contain the previous isp1760 patch from Sebastian ("Implement
solution for erratum 2"). These patches does not apply on top of each other.
Do you want me to rebase my patches so that they apply on top of Linus' latest
tree + Sebastian's patch instead of just Linus' tree?
> Care to redo all 8 of these patches in this manner, so that I can apply them?
>
> thanks,
>
> greg k-h
--
Arvid Brodin
Enea Services Stockholm AB
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
