Hi Sarah, On Wed, Feb 23, 2011 at 07:04:57AM -0800, Sarah Sharp wrote: > Hi Dmitry, > > I guess that casting -1 to a u8 didn't have the effect that I thought it > would. Probably if you'd cast when you did comparison too it woudl work, but I think using a define is clearer still. > > This looks correct, and we probably haven't run into this issue because > all the xHCI host controllers we've run into have well-formed port speed > arrays. I'll queue this. > > On Wed, Feb 23, 2011 at 12:54:37AM -0800, Dmitry Torokhov wrote: > > From 76f7253356a10f698fbd9a3dba3ee633902526ae Mon Sep 17 00:00:00 2001 > > From: Dmitry Torokhov <dtor@xxxxxxxxxx> > > Date: Wed, 23 Feb 2011 00:23:21 -0800 > > Subject: [PATCH] USB: xhci - fix comparison when checking for duplicate ports > > Can you please not send the above bit in future mails? It causes some > pain for maintainers (particularly since git-am accepts it fine, but git > rebase has some serious issues if you leave this bit in the commit > message). Sorry about this, I'll be sending directly from git next time. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
