Re: [PATCH 1/3] USB: gadget: Implement hardware queuing in ci13xxx_udc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/18/2011 7:13 PM, Matthieu CASTET wrote:
> Hi Pavankumar,
> 
> Pavankumar Kondeti a écrit :
>> Chipidea USB controller provides a means (Add dTD TripWire semaphore)
>> for safely adding a new dTD to an active endpoint's linked list.  Make
>> use of this feature to improve performance.  Dynamically allocate and
>> free dTD for supporting zero length packet termination.  Honor
>> no_interrupt flag set by gadget drivers.
>>
> 
> I don't know if you read my "duplicate udc driver for managing tdi core" 
> mail.
> 
Sorry. I missed your email :-(

> fsl_udc_core, ci13xxx_udc, langwell all support TripWire semaphore.
> Idem test mode are already supported by langwell.
> 
In fact I have taken fsl driver as a reference for implementing this patch.
> 
> Instead of adding functionality to each driver won't it better to unify 
> them.
>
Agreed. But I guess it takes a good amount of time to come up with a
unify driver that works for all of the existing users.

We have been using ci13xxx_udc for some time (initially started with a
new driver for MSM and later re-using ci13xxx_udc based on your review
comment). The throughput numbers with ethernet gadget are very low. So
implemented this feature.

Thanks,
Pavan

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux