Hello.
Matthieu CASTET wrote:
TDI driver does the ehci_reset in their reset callback.
Don't reset in ehci_run because configuration settings done in
platform driver will be reset.
This will allow to make msm use ehci_run.
Signed-off-by: Matthieu CASTET <castet.matthieu@xxxxxxxxxx>
Please don't send patches like that, with description and signoff in the
message body and patch body attached. Better not send as attachments at all.
Here's the result of running checkpatch.pl on yor patch:
[headless@wasted usb-2.6]$ scripts/checkpatch.pl
patches/0001-don-t-run-ehci_reset-in-ehci_run-for-tdi-device.patch
ERROR: do not use assignment in if condition
#19: FILE: drivers/usb/host/ehci-hcd.c:682:
+ if (!ehci_is_TDI(ehci) && (retval = ehci_reset(ehci)) != 0) {
ERROR: Missing Signed-off-by: line(s)
total: 2 errors, 0 warnings, 30 lines checked
patches/0001-don-t-run-ehci_reset-in-ehci_run-for-tdi-device.patch has style
problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
