Looks fine, I'll add this to my queue shortly and test.
Sarah Sharp
On Tue, Feb 08, 2011 at 01:55:59PM -0800, Dmitry Torokhov wrote:
> From 37858b400aef2472a85d21b067124864a8757534 Mon Sep 17 00:00:00 2001
> From: Dmitry Torokhov <dtor@xxxxxxxxxx>
> Date: Tue, 8 Feb 2011 13:16:51 -0800
> Subject: [PATCH] USB: xhci - mark local fucntions as static
>
> Functions that are not used outsde of the module they are defined
> should be marked as static.
>
> Signed-off-by: Dmitry Torokhov <dtor@xxxxxxxxxx>
> ---
> drivers/usb/host/xhci-dbg.c | 4 ++--
> drivers/usb/host/xhci-mem.c | 4 ++--
> drivers/usb/host/xhci.c | 8 ++++----
> 3 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-dbg.c b/drivers/usb/host/xhci-dbg.c
> index fcbf4ab..4a83350 100644
> --- a/drivers/usb/host/xhci-dbg.c
> +++ b/drivers/usb/host/xhci-dbg.c
> @@ -449,7 +449,7 @@ char *xhci_get_slot_state(struct xhci_hcd *xhci,
> }
> }
>
> -void xhci_dbg_slot_ctx(struct xhci_hcd *xhci, struct xhci_container_ctx *ctx)
> +static void xhci_dbg_slot_ctx(struct xhci_hcd *xhci, struct xhci_container_ctx *ctx)
> {
> /* Fields are 32 bits wide, DMA addresses are in bytes */
> int field_size = 32 / 8;
> @@ -488,7 +488,7 @@ void xhci_dbg_slot_ctx(struct xhci_hcd *xhci, struct xhci_container_ctx *ctx)
> dbg_rsvd64(xhci, (u64 *)slot_ctx, dma);
> }
>
> -void xhci_dbg_ep_ctx(struct xhci_hcd *xhci,
> +static void xhci_dbg_ep_ctx(struct xhci_hcd *xhci,
> struct xhci_container_ctx *ctx,
> unsigned int last_ep)
> {
> diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
> index 1d0f45f..7604d61 100644
> --- a/drivers/usb/host/xhci-mem.c
> +++ b/drivers/usb/host/xhci-mem.c
> @@ -307,7 +307,7 @@ struct xhci_ep_ctx *xhci_get_ep_ctx(struct xhci_hcd *xhci,
>
> /***************** Streams structures manipulation *************************/
>
> -void xhci_free_stream_ctx(struct xhci_hcd *xhci,
> +static void xhci_free_stream_ctx(struct xhci_hcd *xhci,
> unsigned int num_stream_ctxs,
> struct xhci_stream_ctx *stream_ctx, dma_addr_t dma)
> {
> @@ -335,7 +335,7 @@ void xhci_free_stream_ctx(struct xhci_hcd *xhci,
> * The stream context array must be a power of 2, and can be as small as
> * 64 bytes or as large as 1MB.
> */
> -struct xhci_stream_ctx *xhci_alloc_stream_ctx(struct xhci_hcd *xhci,
> +static struct xhci_stream_ctx *xhci_alloc_stream_ctx(struct xhci_hcd *xhci,
> unsigned int num_stream_ctxs, dma_addr_t *dma,
> gfp_t mem_flags)
> {
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 34cf4e1..4c05777 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -109,7 +109,7 @@ int xhci_halt(struct xhci_hcd *xhci)
> /*
> * Set the run bit and wait for the host to be running.
> */
> -int xhci_start(struct xhci_hcd *xhci)
> +static int xhci_start(struct xhci_hcd *xhci)
> {
> u32 temp;
> int ret;
> @@ -329,7 +329,7 @@ int xhci_init(struct usb_hcd *hcd)
>
>
> #ifdef CONFIG_USB_XHCI_HCD_DEBUGGING
> -void xhci_event_ring_work(unsigned long arg)
> +static void xhci_event_ring_work(unsigned long arg)
> {
> unsigned long flags;
> int temp;
> @@ -857,7 +857,7 @@ unsigned int xhci_last_valid_endpoint(u32 added_ctxs)
> /* Returns 1 if the arguments are OK;
> * returns 0 this is a root hub; returns -EINVAL for NULL pointers.
> */
> -int xhci_check_args(struct usb_hcd *hcd, struct usb_device *udev,
> +static int xhci_check_args(struct usb_hcd *hcd, struct usb_device *udev,
> struct usb_host_endpoint *ep, int check_ep, bool check_virt_dev,
> const char *func) {
> struct xhci_hcd *xhci;
> @@ -1693,7 +1693,7 @@ static void xhci_setup_input_ctx_for_config_ep(struct xhci_hcd *xhci,
> xhci_dbg_ctx(xhci, in_ctx, xhci_last_valid_endpoint(add_flags));
> }
>
> -void xhci_setup_input_ctx_for_quirk(struct xhci_hcd *xhci,
> +static void xhci_setup_input_ctx_for_quirk(struct xhci_hcd *xhci,
> unsigned int slot_id, unsigned int ep_index,
> struct xhci_dequeue_state *deq_state)
> {
> --
> 1.7.3.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
