On Thu, Feb 10, 2011 at 12:00:57PM -0800, Greg KH wrote: > On Thu, Feb 10, 2011 at 09:17:46PM +0200, Felipe Balbi wrote: > > There are several reasons why we would prefer to use what the Kernel > > gives us as infrastructure. But hey, it's your call. Below is the copy > > of the commit which added that check to checkpatch.pl: > > > > commit 3d130fd03e06672f7700e2cb694b29f9a98227ca > > Author: Joe Perches <joe@xxxxxxxxxxx> > > Date: Wed Jan 12 17:00:00 2011 -0800 > > > > checkpatch.pl: add "prefer __packed" check > > > > There's a __packed #define for __attribute__((packed)). Add a checkpatch > > to tell people about it. > > That's great, for new patches, by all means use __packed. > > But for old code, sometimes going through and changing it is a bit > useless, right? Ok. I just feel that it's never too late to update old code. We are constantly doing this: introduce new API and change everybody. Besides it was done with a simple sed script. But ok, we don't need to keep discussing the validity of this patch ;-) I'll be sure to use __packed on new drivers. Thanks -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
