Re: [PATCH] usb/isp1760: Implement Errata 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sergei Shtylyov wrote:
Hello.
Hi,

diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c
index bdba8c5..07761f7 100644
--- a/drivers/usb/host/isp1760-hcd.c
+++ b/drivers/usb/host/isp1760-hcd.c
[...]
@@ -850,6 +851,11 @@ static void enqueue_an_ATL_packet(struct usb_hcd *hcd, struct isp1760_qh *qh,
      skip_map&= ~queue_entry;
      isp1760_writel(skip_map, hcd->regs + HC_ATL_PTD_SKIPMAP_REG);

+    priv->atl_queued++;
+    if (priv->atl_queued == 2)
+        isp1760_writel(INTERRUPT_ENABLE_MASK,
+                hcd->regs + INTERRUPT_ENABLE_SOT_MASK);

   Perhaps it's:

        isp1760_writel(INTERRUPT_ENABLE_[SOT_]MASK,
                hcd->regs + HC_INTERRUPT_ENABLE);

No, it's not perhaps it is what it should be. Very good catch, thank you
Sergei.

   Othrwise it doesn't make much sense...

Right. But now I wonder if this patch is still required since it worked
without the fix. However Russell complained about a short delay.

I'm going to send a new version of this which does the right thing.



WBR, Sergei

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux