Re: [PATCH] usb: gadget: nokia: disallow compilation with HIGHMEM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 08, 2011 at 12:17:46PM +0200, Eero Nurkkala wrote:
> On Tue, 2011-02-08 at 10:03 +0200, ext Felipe Balbi wrote:
> > On Tue, Feb 08, 2011 at 09:30:45AM +0200, ext-eero.nurkkala@xxxxxxxxx wrote:
> > > From: Eero Nurkkala <ext-eero.nurkkala@xxxxxxxxx>
> > > 
> > > With HIGHMEM, g_phonet oopses with the following path:
> > > pn_rx_complete() -> pskb_pull() -> ... kmap_skb_frag() and
> > > oops with BUG_ON(in_irq()). Thus, if the gadget is enabled,
> > > it'd better conflict with the HIGHMEM.
> > > 
> > > Signed-off-by: Eero Nurkkala <ext-eero.nurkkala@xxxxxxxxx>
> > 
> > I'd rather see the real problem fixed rather then working around it. But
> > it's you guys call.
> > 
> 
> Correct. But until it's fixed, this patch may be usable?

It's your call, I don't touch that driver anymore, but IMHO, this patch
is preventing the driver to be used on such situations ;-)

Maybe you Cc Yauheni Kaliuta, he should be the USB guy nowadays, right ?

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux