Hi Marek On Fri, 28 Jan 2011, Marek Szyprowski wrote: > Hello! > > I've ported PTP usb gadget driver created once by Guennadi Liakhovetski > from gadgetfs interface to the new functionfs interface introduced a few > months ago. I've based my work on the sources that are available on > http://git.denx.de/?p=ptp-gadget.git;a=summary > > With functionfs interface one can create usb multifunction composite > gadget with some functions implemented in kernel space (like USB > Ethernet) and other (like the PTP) in userspace. Nice! Thanks a lot for the patch! However, you might appreciate, that reviewing and testing this 1k-line patch wouldn't be very easy for me. It is a huge change. Do I understand it right, that functionfs is replacing the gadgetfs in the kernel? But we still have the "old" kernels around. Would it be difficult to support both interfaces? Best with an automatic detection of what's available on the system - shouldn't be too hard to implement that - you've got both now. What do you think? Thanks Guennadi > > I've tested the new driver with WindowsXP SP3, Windows Vista and Windows > 7. I've managed to get it working together with other usb functions: > RNDIS, Serial ACM and Mass Storage. > > To Guennadi: is it possible to create a separate branch on your PTP > driver git tree? I don't want to completely replace the gadgetfs version > with the functionfs one. For some use cases gadgetfs version might be > more suitable, while for other the functionfs is the only solution. > > Best regards > -- > Marek Szyprowski > Samsung Poland R&D Center > > > Patch summary: > > Marek Szyprowski (1): > PTP: ported from gadgetfs to functionfs kernel interface > > Makefile | 9 +- > README | 2 +- > README-functionfs | 65 +++++ > ptp.c | 800 ++++++++++++++--------------------------------------- > usbstring.c | 142 ---------- > usbstring.h | 38 --- > 6 files changed, 284 insertions(+), 772 deletions(-) > create mode 100644 README-functionfs > delete mode 100644 usbstring.c > delete mode 100644 usbstring.h > > -- > 1.7.1.569.g6f426 > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
