Hi Uwe, On Wed, Jan 19, 2011 at 4:54 PM, Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: ... > can you please fix up the position of the '&'? The original patch had the '&' in the correct position. Looks like it got shifted on some of the replies. > >> >> + Â Â Â Â Â Âv = readl(MX35_IO_ADDRESS(MX35_USB_BASE_ADDR + >> >> + Â Â Â Â Â Â Â Â Â ÂUSBPHYCTRL_OTGBASE_OFFSET)); >> >> + Â Â Â Â Â Âwritel(v | USBPHYCTRL_EVDO, >> >> + Â Â Â Â Â Â Â ÂMX35_IO_ADDRESS(MX35_USB_BASE_ADDR + >> >> + Â Â Â Â Â Â Â Â Â ÂUSBPHYCTRL_OTGBASE_OFFSET)); > I wonder if the address isn't mapped via ioremap in the driver and the > cookie saved somewhere? Â(And no, I don't ask you to change that in this > patch.) Â(If so, it this already problematic aliasing?) This address is only used once here and it is related to the MX35 USB erratum. > >> >> + Â Â Â Â} >> >> + Â Â} >> >> >> > are you sure this compiles when MX35 is not selected ? >> >> Including #include <mach/mx35.h> fixes the build for a non- mx35 kernel. >> >> Would this be acceptable? If so, I can send v2. > If you keep the #if defined(CONFIG_ARCH_MX35) and only add the if > (cpu_is_mx35()) it should work without a new #include. > Doing that seems a tad cleaner to me. Ok, will do as suggested in v2. Thanks, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
