On Wed, Jan 19, 2011 at 11:38:44PM +0800, Ming Lei wrote: > Hi, > > 2011/1/19 Felipe Balbi <balbi@xxxxxx>: > > > that's easy to guess since commit log says it's a problem on Meego > > kernel. > > OK, it is a specific issue on Meego kernel, so it is better to add > "Meego " in the patch title. > > > > >> Are you sure the issue can be reproduced in 2.6.37 or -next tree? > >> > >> In mainline code(2.6.37), blocking_notifier_call_chain is only called in > >> threaded irq handler of otg driver wrt. musb driver, so seems enough. > > > > true, but seems like Nokia is using to notify gadget states, which makes > > a lot of sense when you start thinking about things such as battery > > charging. > > Please go ahead to submit and merge it into mainline first if it makes > sense, :-) isn't it what his patch is already intending to do ? Or do you want them to send the initial buggy version and only afterwards send the bugfix ? A bit weird decision wouldn't that be ? -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
