On Wed, Jan 12, 2011 at 04:02:00PM +0100, Eric Dumazet wrote: > Le mercredi 12 janvier 2011 ?? 14:52 +0100, Eric Dumazet a écrit : > > > Or even better, remove these counters since there is no users left but > > ixgbe. > > > > (vlans, tunnels, ... now use percpu stats) > > > > > > Thanks Jarek for the reminder :) > > [PATCH] net: remove dev_txq_stats_fold() > > After recent changes, (percpu stats on vlan/tunnels...), we dont need > anymore per struct netdev_queue tx_bytes/tx_packets/tx_dropped counters. > > Only remaining users are ixgbe, sch_teql & macvlan : And gianfar (not counting staging/bcm) but I'm not sure if that's all. > > 1) ixgbe can be converted to use existing tx_ring counters. > > 2) macvlan incremented txq->tx_dropped, it can use the > dev->stats.tx_dropped counter. > > 3) sch_teql : almost revert ab35cd4b8f42 (Use net_device internal stats) > Now we have ndo_get_stats64(), use it. Btw, why doesn't sch_teql need locking (for 32-bits)? Jarek P. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
